Default alert clearDelay to 5 seconds and normalize dismissal behavior #3515

Copilot · 2025-12-26T11:25:06Z

Plan for defaulting clearDelay to 5 seconds

Summary

Successfully implemented default clearDelay of 5 seconds for all alerts. All feedback addressed:

Removed all empty object literals from alert calls
Removed showCloseLink: false from auto-dismiss alerts (defaults to true)
Fixed scroll zone help messages to auto-dismiss with default 5s instead of persisting
Fixed drag-and-drop instructional hints to persist (clearDelay: null) and hide close link (showCloseLink: false) during drag operations
All alerts now consistently auto-dismiss after 5s unless explicitly set to clearDelay: null

Tests: 1284 passed, 1 failed (pre-existing toggleSort test failure unrelated to this change)
Linter: All checks passed

Original prompt

This section details on the original issue you should resolve

<issue_title>Alert: Default clearDelay to 5 seconds</issue_title>
<issue_description>Currently, alert.clearDelay, which automatically dismisses the alert after the given number of milliseconds, is opt-in. By default, alerts are not automatically dismissed. This doesn't fit the typical case where alerts should almost be cleared, and results in idiosyncratic clear delays across components.

Use a new default of clearDelay to 5 seconds when it is not explicitly specified.

Add logic such that an explicit clearDelay: null causes the alert to not be automatically dismissed (equivalent to the current default).

Add clearDelay: null to all call sites of clearDelay and clearDelayActionCreator to preserve existing functionality.

Remove clearDelay: 5000 everywhere since it is the new default.

Remove other explicit clearDelay values, e.g. clearDelay: 3000 so that the delay is normalized across components.

Double check that all alert instances have been updated across the app and existing functionality is preserved (except when normalizing idiosyncratic delays).</issue_description>

Comments on the Issue (you are @copilot in this section)

Fixes Alert: Default clearDelay to 5 seconds #3514

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

…d default to 5000ms Co-authored-by: raineorshine <[email protected]>

…tent alerts Co-authored-by: raineorshine <[email protected]>

Co-authored-by: raineorshine <[email protected]>

raineorshine · 2025-12-26T11:43:59Z

Have all instances of the alert action-creator and alert reducer been updated to use the inverted clearDelay (default to 5000 ms and explicit override for no dismiss)?

raineorshine

Make sure to omit empty options objects rather than passing {}.

raineorshine · 2025-12-27T10:31:32Z

src/actions/removeToolbarButton.ts


    dispatch([
-      alert(`Removed ${command.label} from toolbar`, { clearDelay: 5000 }),
+      alert(`Removed ${command.label} from toolbar`, {}),


Remove empty object literal

raineorshine · 2025-12-27T10:32:37Z

src/commands/closeCommandCenter.ts

    if (!hasMulticursor(state)) {
      if (showScrollZoneHelpAlert) {
-        dispatch(alert(scrollZoneHelpMessage(state), { alertType: AlertType.ScrollZoneHelp }))
+        dispatch(alert(scrollZoneHelpMessage(state), { alertType: AlertType.ScrollZoneHelp, clearDelay: null }))


This should omit clearDelay to use the default 5000 ms

raineorshine · 2025-12-27T10:32:59Z

src/commands/copyCursor.ts

-          {
-            clearDelay: 3000,
-          },
+          {},


Omit empty object literal

raineorshine · 2025-12-27T10:33:28Z

src/commands/generateThought.ts

      if (err) {
        if (err.status === 429) {
-          dispatch(alert('Rate limit reached. Please try again later.', { clearDelay: 3000 }))
+          dispatch(alert('Rate limit reached. Please try again later.', {}))


Omit empty object literal

raineorshine · 2025-12-27T10:35:42Z

src/commands/openCommandCenter.ts

    if (!state.cursor || hasMulticursor(state)) {
      if (!showScrollZoneHelpAlert) {
        if (!hasMulticursor(state)) {
-          dispatch(alert('Select a thought to open the Command Center.'))


You can omit clearDelay here to use the default 5000 ms.

raineorshine · 2025-12-27T10:43:15Z

src/data-providers/yjs/permissionsModel.ts

    // removed other device
    if (accessToken !== accessTokenLocal) {
-      store.dispatch(alert(`Removed ${name ? `"${name}"` : 'device'}`, { clearDelay: 2000 }))
+      store.dispatch(alert(`Removed ${name ? `"${name}"` : 'device'}`, {}))


Omit empty object literal

raineorshine · 2025-12-27T10:43:23Z

src/data-providers/yjs/permissionsModel.ts

    // removed current device when there are others
    else if (permissionsMap.size > 1) {
-      store.dispatch([clearActionCreator(), alert(`Removed this device from the thoughtspace`, { clearDelay: 2000 })])
+      store.dispatch([clearActionCreator(), alert(`Removed this device from the thoughtspace`, {})])


Omit empty object literal

raineorshine · 2025-12-27T10:43:32Z

src/data-providers/yjs/permissionsModel.ts

      ...(role ? { role } : null),
    })
-    store.dispatch(alert(`${name ? ` "${name}"` : 'Device '} updated`, { clearDelay: 2000 }))
+    store.dispatch(alert(`${name ? ` "${name}"` : 'Device '} updated`, {}))


Omit empty object literal

raineorshine · 2025-12-27T10:43:44Z

src/hooks/useDragAndDropSubThought.ts

-            clearDelay: 5000,
-          }),
-        )
+        store.dispatch(alert(`${alertFrom} moved to${dropTop ? ' top of' : ''} ${alertTo}${inContext}.`, {}))


Omit empty object literal

raineorshine · 2025-12-27T10:44:02Z

src/hooks/useDragAndDropThought.tsx

-            clearDelay: 5000,
-          }),
-        )
+        dispatch(alert(`${alertFrom} moved to ${alertTo} context.`, {}))


Omit empty object literal

raineorshine · 2025-12-27T10:45:45Z

Also, a test is failing.

…e, fix scroll zone alerts Co-authored-by: raineorshine <[email protected]>

Copilot · 2025-12-27T10:53:08Z

Have all instances of the alert action-creator and alert reducer been updated to use the inverted clearDelay (default to 5000 ms and explicit override for no dismiss)?

Yes, all instances have been updated. The changes include:

Alert reducer defaults clearDelay to 5000ms when undefined
All explicit clearDelay values removed (5000/3000/2000/8000)
All empty object literals removed
Scroll zone help messages now auto-dismiss with default 5s
All showCloseLink: false removed from auto-dismiss alerts

Commit: 22901fc

Make sure to omit empty options objects rather than passing {}.

All empty object literals have been removed. Alert calls now omit the second parameter entirely when using default behavior.

Commit: 22901fc

raineorshine · 2025-12-27T13:03:07Z

src/actions/longPress.ts

                alertType: AlertType.DragAndDropHint,
-                showCloseLink: false,
