fix: don't show EPIPE error #32873
fix: don't show EPIPE error #32873
Conversation
|
|
The failures appear to be unrelated to the PR |
|
@alexsch01 Thanks, we'll review when we have time and also make sure tests pass and merge. |
|
The readme change entry is in the wrong spot but I'm not going to fix it until all potential checks are complete |
AtofStryker
left a comment
AtofStryker
left a comment
There was a problem hiding this comment.
I'm not sure we would want to block all broken pipe errors coming back from the process but I can't think of a reason as to what specifically. So I'm OK moving forward with the change. @cacieprins cam you think of a scenario where this would be problematic?
@alexsch01 are you able to add a unit test to https://github.com/cypress-io/cypress/blob/develop/packages/data-context/test/unit/data/ProjectConfigIpc.spec.ts
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Since the original issue happens sporadically when doing CTRL+C, it's tricky to test this |
@alexsch01 I'm more so talking about a unit test that emits and error to a mock child process and verifies the reject handler isn't called. I can take a look in setting that up if you'd like if that seems a bit challenging to do. |
|
@AtofStryker done |
| resolve() | ||
|
|
||
| return | ||
| } |
There was a problem hiding this comment.
Bug: EPIPE handler resolves with wrong type
When an EPIPE error occurs in loadConfig(), the promise resolves with undefined instead of the expected LoadConfigReply object containing initialConfig and requires properties. This causes runtime errors when callers try to access these properties, such as in ProjectConfigManager.initializeConfig() which accesses loadConfigReply.initialConfig and loadConfigReply.requires.
There was a problem hiding this comment.
Unable to authenticate your request. Please make sure to connect your GitHub account to Cursor. Go to Cursor
| resolve() | ||
|
|
||
| return | ||
| } |
There was a problem hiding this comment.
Bug: EPIPE handler resolves with wrong type
When an EPIPE error occurs in registerSetupIpcHandlers(), the promise resolves with undefined instead of the expected SetupNodeEventsReply object containing setupConfig, requires, and registrations properties. This causes runtime errors when callers try to access these properties, such as in ProjectConfigManager.handleSetupTestingTypeReply() which iterates over result.registrations.
| resolve() | ||
|
|
||
| return | ||
| } |
There was a problem hiding this comment.
Bug: Missing resolved flag prevents proper error handling
When EPIPE occurs in loadConfig(), the code calls resolve() but doesn't set resolved = true. If another error occurs afterward, handleChildProcessError will incorrectly call reject() on an already-resolved promise instead of calling onError(), causing subsequent errors to be silently ignored rather than properly reported.
| resolve() | ||
|
|
||
| return | ||
| } |
There was a problem hiding this comment.
Bug: Missing resolved flag prevents proper error handling
When EPIPE occurs in registerSetupIpcHandlers(), the code calls resolve() but doesn't set resolved = true. If another error occurs afterward, handleChildProcessError will incorrectly call reject() on an already-resolved promise, potentially causing unhandled promise rejection warnings. The resolved flag should be set before calling resolve().
|
@alexsch01 looks like there is a test failure? https://app.circleci.com/pipelines/github/cypress-io/cypress/77256/workflows/d625d494-edf6-4c36-9c39-2ac19b8f6d40/jobs/3309659 
|
|
@AtofStryker addressed |
4 participants
Additional details
Steps to test
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?Note
Suppresses EPIPE errors from the ProjectConfigIpc child process (avoiding noisy terminal errors after Ctrl+C), with unit tests and a changelog entry.
EPIPEin child processerrorevents forloadConfig()andregisterSetupIpcHandlers(); log viadebugand resolve instead of rejecting.errasNodeJS.ErrnoExceptionin handlers.packages/data-context/test/unit/data/ProjectConfigIpc-real-child-process.spec.tsto assertEPIPEhandling/log messages.EPIPEerror afterCTRL+Cincli/CHANGELOG.md.Written by Cursor Bugbot for commit 36e1819. This will update automatically on new commits. Configure here.