Skip to content

Conversation

@AtofStryker
Copy link
Contributor

@AtofStryker AtofStryker commented Nov 6, 2025

  • Closes

Additional details

Converts the tests in WBIP to use Vitest and TypeScript. to prevent collisions between the source and compiled files under test, I moved the compiled files to a dist directory and updated the main entry

Steps to test

How has the user experience changed?

PR Tasks


Note

Migrates @cypress/webpack-batteries-included-preprocessor to Vitest/TypeScript tests and dist-based output, updating configs and internal references.

  • npm/webpack-batteries-included-preprocessor:
    • Testing: Migrate from Mocha/Chai/Sinon to vitest; convert unit/e2e tests to TypeScript; add vitest.config.ts.
    • Build/Output: Change package entry to dist/index.js and types to dist/index.d.ts; set tsconfig.json outDir to dist; update tests to import from dist.
    • Scripts/Deps: Replace Mocha test script with vitest; add test-debug; add vitest dev dep; remove legacy test deps; refine ESLint config (remove ignored entry files, set tsconfigRootDir).
  • Internal references:
    • Update paths to npm/@cypress/webpack-batteries-included-preprocessor/dist/index.js in scripts/binary/binary-cleanup.js and comment in packages/web-config/webpack.config.base.ts.
  • Docs:
    • Mark npm/webpack-batteries-included-preprocessor as ✅ completed in guides/esm-migration.md.

Written by Cursor Bugbot for commit 7a5b02c. This will update automatically on new commits. Configure here.

@AtofStryker AtofStryker self-assigned this Nov 6, 2025
@cypress
Copy link

cypress bot commented Nov 6, 2025

cypress    Run #67228

Run Properties:  status check passed Passed #67228  •  git commit 7a5b02cbe9: misc: convert @cypress/webpack-batteries-included-preprocessor tests to vitest
Project cypress
Branch Review chore/wbip-vitest
Run status status check passed Passed #67228
Run duration 19m 08s
Commit git commit 7a5b02cbe9: misc: convert @cypress/webpack-batteries-included-preprocessor tests to vitest
Committer Bill Glesias
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 12
Tests that did not run due to a developer annotating a test with .skip  Pending 1098
Tests that did not run due to a failure in a mocha hook  Skipped 4
Tests that passed  Passing 26530
View all changes introduced in this branch ↗︎

Warning

Partial Report: The results for the Application Quality reports may be incomplete.

UI Coverage  45.61%
  Untested elements 187  
  Tested elements 161  
Accessibility  97.98%
  Failed rules  4 critical   8 serious   2 moderate   2 minor
  Failed elements 101  

@jennifer-shehane jennifer-shehane self-requested a review November 6, 2025 20:31
@jennifer-shehane jennifer-shehane self-requested a review November 6, 2025 20:40
@jennifer-shehane
Copy link
Member

@AtofStryker I think there's a legitimate failure due to this in our published artifacts. I may have reviewed this too early - sorry if so.

@AtofStryker
Copy link
Contributor Author

@AtofStryker I think there's a legitimate failure due to this in our published artifacts. I may have reviewed this too early - sorry if so.

@jennifer-shehane no worries its related to the binary-cleanup. I'll fix it and push it up

Base automatically changed from chore/wbip-ts to develop November 7, 2025 20:44
@AtofStryker
Copy link
Contributor Author

this is going to fail semantic pull request because I edited the web-config package. This is expected and I am going to have to ignore the changelog valication until after next release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants