Skip to content

chore(deps): update dependency karma-browserify to v8 #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

chore(deps): update dependency karma-browserify to v8 #61

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@
"coveralls": "^3.0.2",
"function-bind": "^1.0.2",
"karma": "^3.0.0",
"karma-browserify": "^5.0.1",
"karma-browserify": "^8.0.0",
Comment on lines 64 to +65
Copy link

@graphite-app graphite-app bot Dec 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This upgrade introduces a version compatibility issue. [email protected] requires [email protected] or higher, but the project currently uses [email protected]. To resolve this, either:

  1. Keep [email protected], or
  2. Upgrade karma to version 6.x or higher

The current combination of versions will cause runtime errors.

Spotted by Graphite Reviewer

Is this helpful? React 👍 or 👎 to let us know.

Copy link

@MikeMcC399 MikeMcC399 Dec 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The peer dependencies of [email protected] are "karma": ">=4.3.0".

The graphite app did not explain why it thought that karma@6 is required. It could be true, but we don't know why.

"karma-cli": "^2.0.0",
"karma-coverage": "^2.0.3",
"karma-phantomjs-launcher": "^1.0.0",
Expand Down
Loading