Skip to content

Conversation

@kgal-akl
Copy link

Description

Add the Akeyless Secret Store component.

Issue reference

dapr/components-contrib#4036

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

Copy link
Contributor

@cicoyle cicoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR 🎉 mostly lgtm, but we will need a go.mod and go.sum diff in this PR as well once the contrib PR is merged.

@kgal-akl
Copy link
Author

kgal-akl commented Dec 8, 2025

Thanks for the PR 🎉 mostly lgtm, but we will need a go.mod and go.sum diff in this PR as well once the contrib PR is merged.

@cicoyle - No problem! You mean that I need to add the same changes to this PR?

@cicoyle
Copy link
Contributor

cicoyle commented Dec 12, 2025

Thanks for the PR 🎉 mostly lgtm, but we will need a go.mod and go.sum diff in this PR as well once the contrib PR is merged.

@cicoyle - No problem! You mean that I need to add the same changes to this PR?

Hey! Thanks for noticing - we are sisters, twins actually 👯‍♀️ :)

sorry its unclear, let me try to explain with a clear example -

This dapr PR updated the go.sum + go.mod in dapr/dapr based on the new commit sha from the related dapr/components-contrib PR here. You should be able to run a go get ... + make modtidy-all (from root) or update that line in your go.mod from your ide, I use goland and it automagically updates it for me. Once you get the merge commit sha (once the contrib PR is merged) you'll want to grab the sha and update the go.mod line with the latest sha so CI resolves and is happy in this PR.

This is necessary as components-contrib is just a library we import in dapr/dapr.

So, you don't need to do anything quite yet until the contrib PR is merged. Lmk if I can help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants