Skip to content

Conversation

@dphiffer
Copy link

@dphiffer dphiffer commented Oct 2, 2024

This PR attempts to bring the project up to speed with modern node.js:

  1. Updates packages to use ESM style import and export rather than require() and module.exports (forced in part because dependency parse-favicon refused to work using CommonJS).
  2. Replaces deprecated request package with calls to native fetch().
  3. Updates other packages to latest versions.
  4. Adds an .nvmrc to nudge users toward node.js LTS v22.
  5. Updates package.json engines to v18.0.0 in order to get fetch() without needing to pass an experimental argument.
  6. Switches config.json to config.js to make it work more easily with ESM imports.
  7. Some opinionated whitespace changes from my text editor. (I can back them out if they're annoying.)

@dphiffer dphiffer closed this Aug 29, 2025
@dariusk
Copy link
Owner

dariusk commented Aug 29, 2025

Hey Dan, ok with you if I reopen this? I'm starting to get back into caretaking my old projects again and this seems like useful work for me to incorporate 😅

@dphiffer
Copy link
Author

dphiffer commented Aug 29, 2025

Yeah, fine with me! I was looking through my pull requests and trying to prune things that seemed unlikely to land. I might also be starting to withdraw my engagement with this AI company where I can.

@dphiffer dphiffer reopened this Aug 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants