update MCPClient.connectStdioServer to operate on streams and sinks #204
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
type-infra
PR HealthChangelog Entry ✔️
Changes to files need to be accounted for in their respective changelogs. |
gspencergoog
approved these changes
Jun 27, 2025
Contributor
gspencergoog
left a comment
gspencergoog
left a comment
There was a problem hiding this comment.
Oh, yes, this is much better.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated MCPClient.connectStdioServer to take a stdin and stdout stream instead of a binary name and arguments. It no longer spawns processes on its own. This removes the
dart:iodependency and allows more flexibility for how processes are spawned (can use package:process or even no process at all).The migration is pretty easy, just launch your own process and pass in stdin/stdout from that.