Implement greatCircle #214
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
lukas-h
requested changes
Apr 9, 2025
Member
lukas-h
left a comment
lukas-h
left a comment
There was a problem hiding this comment.
make sure we make full use of dart's static types + the types from our base package geotypes
lib/src/great_circle.dart
Outdated
| /// | ||
| /// Useful link: https://en.wikipedia.org/wiki/Great-circle_distance | ||
|
|
||
| List<List<double>> greatCircle( |
Member
There was a problem hiding this comment.
please make sure our function returns something similar to the turfJS version.
Let's return a Feature with either
a LineString or MultiLineString as the payload.
lib/src/great_circle.dart
Outdated
| /// Useful link: https://en.wikipedia.org/wiki/Great-circle_distance | ||
|
|
||
| List<List<double>> greatCircle( | ||
| dynamic start, |
Member
There was a problem hiding this comment.
instead of dynamic please choose a more concrete type (the JS version asks for coordinates, which would equal to our Position type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.