Fix: Code correction for code examples in address.md #169
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* docs: update header and badges * docs: readme link and typo fixes * docs: fix README badge URLs * docs: fix travis URL
* rem TODO * add member selecting functions * refactor and jsdoc * getModifier -> getSelectionModifier * correct jsdoc description * inital functions * add copy function * copy mnList * remove bitset dependency * add bls-signatures dependency * bump version * bump version to 0.18.10 * update package lock * refactor * using BLS * isValidQuorumSig test * isValidMemberSig test * update diff fixture * pass network to diff in applyDiff * update quorum fixtures * aggregated memberSig verification * member fixture * quorum member tests * add bitarray functions * aggregate only if signer's bit set * delete BLS bindings variables * refactor * don't reverse bits * add mnList fixture for non-max signed quorum * add test for non-max signed quorum * don't copy mnList * test quorum.verify() * getQuorums functions * getUnverifiedQuorums function * destructuring * alphabetize a few things * throw error when verifying outdated * add fs:empty to webpack.config * remove ChromeHeadless browser tests * get quorums tests * remove line from description * bump version * update package lock * bump version to 0.19.0 * bump version to 0.19.0-dev.1 * use .filter in calculateScores * use .filter in quorum getters * remove extra line
BREAKING CHANGES: QuorumEntry#verify, QuorumEntry#isValidQuorumSig and QuorumEntry#isValidMemberSig methods now return promise
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Code has missing ")" for the if clause
What was done?
Added missing ")" to the if clause