Skip to content

Conversation

@xdustinface
Copy link
Collaborator

This is a general CI overhaul which will not pass yet but i will work on getting there while this stays a draft.

Summary

  • Add cargo-deny security audit for vulnerability and license checking
  • Add MSRV (1.89) verification job
  • Add documentation build check
  • Add Windows to tests and pre-commit
  • Rewrite test workflow with grouped multi-platform matrix (Linux x86/ARM, macOS, Windows)
  • Add verify-coverage job that fails if any crate isn't assigned to a test group
  • Drop the complex segfault detection logic in the SPV part which was actually hiding test failures
  • Add x86_64 runner to fuzz workflow alongside ARM for cross-architecture coverage
  • Add enable concurrency control in pre-commit.yml to cancel redundant runs

Test Groups

Tests are now organized in .github/ci-groups.yml. CI fails if a new crate is added without being assigned to a group.

Jobs: 4 → ~25 (parallel)

  • 20 test jobs (5 groups (core, spv, wallet, rpc, tools) × 4 platforms (ubuntu arm, ubuntu x86_64, macos, windows))
  • security, msrv, docs build, verify-coverage

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 7, 2025

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch ci/overhaul

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

This is a general CI overhaul which will not pass yet but i will work on getting there while this stays a draft.

### Summary

  - Add `cargo-deny` security audit for vulnerability and license checking
  - Add MSRV (1.89) verification job
  - Add documentation build check
  - Add Windows to tests and pre-commit
  - Rewrite test workflow with grouped multi-platform matrix (Linux x86/ARM, macOS, Windows)
  - Add `verify-coverage` job that fails if any crate isn't assigned to a test group
  - Drop the complex segfault detection logic in the SPV part which was actually hiding test failures
  - Add x86_64 runner to fuzz workflow alongside ARM for cross-architecture coverage
  - Add enable concurrency control in `pre-commit.yml` to cancel redundant runs

  ### Test Groups
  Tests are now organized in `.github/ci-groups.yml`. CI fails if a new crate is added without being assigned to a group.

  ### Jobs: 4 → ~25 (parallel)
  - 20 test jobs (5 groups (core, spv, wallet, rpc, tools) × 4 platforms (ubuntu arm, ubuntu x86_64, macos, windows))
  - security, msrv, docs build, verify-coverage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants