-
Notifications
You must be signed in to change notification settings - Fork 4
assorted (linting) fixes, dependency updates and test-fixes #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
thaJeztah
wants to merge
10
commits into
data-accelerator:main
Choose a base branch
from
thaJeztah:general_cleanup
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sebastiaan van Stijn <[email protected]>
Update the version of github.com/containerd/accelerated-container-image to v1.2.0, which is the minimum version supporting containerd v2. Signed-off-by: Sebastiaan van Stijn <[email protected]>
Updating to the v2.0.4 patch release as minimum, which includes [c8d@3d53430] to reduce some (indirect) dependencies, and [c8d@f341477] to downgrade some unreleased versions of dependencies. The v2.0.4 release included a security fix for [CVE-2024-40635], so updating to that version to avoid potential security alerts. I did not update to the latest version because this project is used as dependency for other modules, and containerd v2.0.5 also updated the minimum Go version to 1.23. [c8d@3d53430]: containerd/containerd@3d53430 [c8d@f341477]: containerd/containerd@f341477 [CVE-2024-40635]: GHSA-265r-hfxg-fhmg Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
These were added in the initial bc443fe commit, but appear to be unused. Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
On a Unix system, this doesn't make a big difference, but filepath.Join is the preferred use for file paths (regardless if it's forward or backward slashes). path.Join is still used for constructing URLs, which always use forward slashes. Signed-off-by: Sebastiaan van Stijn <[email protected]>
Use stdlib native error-wrapping so that we can remove the direct dependency on github.com/pkg/errors. Signed-off-by: Sebastiaan van Stijn <[email protected]>
Update tests to use designated rfc6761 test domains; the tests didn't require an actual domain to resolve; for such cases, it's generally recommended to use [rfc6761] designated domains. Also: - fix TestParse: the test was only printing the result, but didn't test it to be correct. - use consts for fixed values - remove uses of testify: the tests currently only used a very minimal subset of its functionality, so replacing it with stdlib to reduce the dependency tree. - remove hard-coded temp-dir from test. Use `t.TempDir()` to provide the path and to clean up after the test if anything would fail. [rfc6761]: https://www.rfc-editor.org/rfc/rfc6761.html#section-6.2 Signed-off-by: Sebastiaan van Stijn <[email protected]>
This allows consumers of this module to use the context-logger that's defined through containerd's log package. If no logger is defined, it uses logrus' standard logger. Signed-off-by: Sebastiaan van Stijn <[email protected]>
Author
|
@BigVan @WaberZhuang PTAL |
Author
|
@BigVan @WaberZhuang PTAL 🫶 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
go.mod: remove toolchain directive
go.mod: update github.com/containerd/accelerated-container-image v1.2.x
Update the version of github.com/containerd/accelerated-container-image
to v1.2.0, which is the minimum version supporting containerd v2.
go.mod: update containerd dependency to stable v2.0.x
Updating to the v2.0.4 patch release as minimum, which includes
c8d@3d53430 to reduce some (indirect) dependencies, and c8d@f341477
to downgrade some unreleased versions of dependencies. The v2.0.4
release included a security fix for CVE-2024-40635, so updating to
that version to avoid potential security alerts. I did not update to
the latest version because this project is used as dependency for
other modules, and containerd v2.0.5 also updated the minimum Go version
to 1.23.
gofmt code
remove unused zdfsIsReady, pouchDirLock, blockEngine vars
These were added in the initial bc443fe
commit, but appear to be unused.
remove uses of deprecated io/ioutil
use filepath for joining file paths
On a Unix system, this doesn't make a big difference, but filepath.Join
is the preferred use for file paths (regardless if it's forward or backward
slashes). path.Join is still used for constructing URLs, which always use
forward slashes.
remove uses of github.com/pkg/errors in favor of stdlib
Use stdlib native error-wrapping so that we can remove the direct
dependency on github.com/pkg/errors.
update and fix tests
Update tests to use designated rfc6761 test domains; the tests didn't
require an actual domain to resolve; for such cases, it's generally
recommended to use rfc6761 designated domains.
Also:
test it to be correct.
subset of its functionality, so replacing it with stdlib to reduce
the dependency tree.
t.TempDir()to providethe path and to clean up after the test if anything would fail.
replace direct uses of logrus for containerd/log
This allows consumers of this module to use the context-logger that's
defined through containerd's log package. If no logger is defined, it
uses logrus' standard logger.