Skip to content

Conversation

@BohuTANG
Copy link
Member

Bump version to 0.2.9

@BohuTANG BohuTANG merged commit 34913e3 into main Nov 27, 2025
5 checks passed
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines 1417 to +1420
def _inner_field_to_string(field: pa.Field) -> str:
# inner field default is NOT NULL in databend
type_str = _field_type_to_string(field)
return f"{type_str} NULL" if field.nullable else type_str
return f"{type_str} NOT NULL" if not field.nullable else type_str

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Preserve NULLability in table output columns

Table-valued UDFs with nullable result columns are now emitted without an explicit NULL marker: _inner_field_to_string returns only the type when field.nullable is true even though the comment notes inner fields default to NOT NULL in Databend. That causes RETURNS TABLE (...) definitions to register nullable columns as NOT NULL, so UDFs that actually return nulls will have a mismatched signature and can fail at runtime. Please keep emitting NULL when a result field is nullable.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants