[PECOBLR-1302]add telemetry for metric view #1115
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samikshya-db
approved these changes
Nov 28, 2025
Collaborator
samikshya-db
left a comment
samikshya-db
left a comment
There was a problem hiding this comment.
LGTM. But, let's merge this only after telemetry proto has the enable_metric_view_metadata field. [internal link]
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds telemetry tracking for the metric view metadata feature by including the enable_metric_view_metadata parameter in connection telemetry data.
- Adds
enableMetricViewMetadatafield toDriverConnectionParametersmodel - Updates telemetry helper to populate the new field from connection context
- Includes the field in the string representation for debugging
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/main/java/com/databricks/jdbc/telemetry/TelemetryHelper.java | Populates the new enableMetricViewMetadata field in telemetry data from connection context |
| src/main/java/com/databricks/jdbc/model/telemetry/DriverConnectionParameters.java | Adds enableMetricViewMetadata boolean field with setter method and includes it in toString output |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/main/java/com/databricks/jdbc/telemetry/TelemetryHelper.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add metric view param to telemetry
Testing
Unit test
Additional Notes to the Reviewer
NO_CHANGELOG=true