Add fall back to all exceptions encountered when presigned URL is not available for upload and download in FilesExt #1115
+100
−78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuanjieding-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
parthban-db
changed the title
parthban-db
reviewed
Nov 13, 2025
Contributor
parthban-db
left a comment
parthban-db
left a comment
There was a problem hiding this comment.
Can you also add this change in the changelog?
| len(pre_read_buffer), | ||
| session_token, | ||
| BytesIO(pre_read_buffer), | ||
| is_first_part=True, |
Contributor
There was a problem hiding this comment.
Do we need to pass this information? Every error returned by this will fall back to FilesAPI, right?
Collaborator
Author
There was a problem hiding this comment.
We do need this information for two reasons:
- Whenever it is not possible to use Presigned URL, the SDK should fail at the first part. Otherwise client should retry.
- For uploading of unseekable streams, if the function fails at any part other than the first part, the previous parts would been dropped from memory and thus not possible to perform a fallback. In that case the SDK has no option but throw an exception, and the client should perform a retry.
yuanjieding-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
parthban-db
approved these changes
Nov 18, 2025
|
If integration tests don't run automatically, an authorized user can run them manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
WHAT
FilesExtWHY
How is this tested?
Unit tests are updated to reflect the change.