-
Notifications
You must be signed in to change notification settings - Fork 225
Adjective faker based on existing YML file. Generated by Grok Fast 1. #1730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
PR Summary
|
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1730 +/- ##
=========================================
Coverage 92.32% 92.33%
- Complexity 3434 3439 +5
=========================================
Files 337 338 +1
Lines 6779 6785 +6
Branches 670 670
=========================================
+ Hits 6259 6265 +6
Misses 354 354
Partials 166 166 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kingthorin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
asolntsev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but arises few questions:
- Why did we need the file
adjective.ymlif we didn't use it (before this PR)? - How this "adjective" differs from
words.adjective? - Don't we have duplication in files
adjective.ymlandwords.yml/adjective?
|
Ha! I didn't bother to check, good catch. |
|
We don't have a faker class for all YML files. There's a small gap. I knew we had a adjective, but I couldn't find it, so there might be overlap. I'll investigate which one we need. |
No description provided.