Skip to content

Conversation

@bodiam
Copy link
Contributor

@bodiam bodiam commented Dec 9, 2025

No description provided.

@what-the-diff
Copy link

what-the-diff bot commented Dec 9, 2025

PR Summary

  • New functionality for word generation
    A new feature has been introduced in the program that allows it to generate random adjectives. Adjectives could be of any type: negative, positive or any other category. This has been achieved by adding a new class in the system called Adjective.

  • Enhanced existing module
    The existing system component, BaseProviders, has been enhanced with an additional function. This new method, referred to as adjective(), provides the ability to get instances for the new Adjective class.

  • Updated system resource
    The changes to the system include an update to the system's file list. In EnFile, an entry for a new file adjective.yml has been added.

  • Tested the new feature
    For ensuring reliability and accuracy of the new feature, a series of unit tests have been created under AdjectiveTest. These tests confirm that the newly added methods in the Adjective class: positive(), negative(), and any() work as expected by returning not null and non-empty results.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.33%. Comparing base (c174d5a) to head (db07c7e).
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #1730   +/-   ##
=========================================
  Coverage     92.32%   92.33%           
- Complexity     3434     3439    +5     
=========================================
  Files           337      338    +1     
  Lines          6779     6785    +6     
  Branches        670      670           
=========================================
+ Hits           6259     6265    +6     
  Misses          354      354           
  Partials        166      166           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Collaborator

@kingthorin kingthorin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@asolntsev asolntsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but arises few questions:

  1. Why did we need the file adjective.yml if we didn't use it (before this PR)?
  2. How this "adjective" differs from words.adjective?
  3. Don't we have duplication in files adjective.yml and words.yml/adjective?

@asolntsev asolntsev added this to the 2.6.0 milestone Dec 9, 2025
@kingthorin
Copy link
Collaborator

Ha! I didn't bother to check, good catch.

@erikpragt-connectid
Copy link

We don't have a faker class for all YML files. There's a small gap. I knew we had a adjective, but I couldn't find it, so there might be overlap.

I'll investigate which one we need.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants