-
Couldn't load subscription status.
- Fork 140
memory usage estimator #553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Before you submit for review:
If you did not complete any of these, then please explain below. |
| return new IndexConfig( | ||
| dimension, | ||
| 16, | ||
| 1.5f, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: We generally default to 1.2 for overflowRatio
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
noted, I'll follow this PR up with an improved one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adds some useful functionality
This is a utility that we can use to get an empirical estimation of how much heap a given index or indexing process will take. It is a part of a larger strategy for managing heap usage safely.
Why? Here are the key reasons: