Skip to content

Make the thresholds in TestLowCardinalityFiltering tighter #559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Make the thresholds in TestLowCardinalityFiltering tighter #559

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7a9b75d
Reduce the number of vectors in TestLowCardinalityFiltering and adjus…
marianotepper Oct 24, 2025
31f0b49
Add description to the test
marianotepper Oct 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions jvector-tests/src/test/java/io/github/jbellis/jvector/graph/TestLowCardinalityFiltering.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,15 +45,19 @@

@ThreadLeakScope(ThreadLeakScope.Scope.NONE)
public class TestLowCardinalityFiltering extends LuceneTestCase {
/*
This test replicates https://github.com/jbellis/pwtest/tree/master natively in JVector.
It splits the vectors in two classes (with probability 0.5) and tests that the filtering works when the query belongs to one of them.
*/
@Test
public void testLowCardinalityFiltering() throws IOException {
testLowCardinalityFiltering(32, 0.01f, 0.87f, false);
testLowCardinalityFiltering(32, 0.01f, 0.87f, true);
testLowCardinalityFiltering(32, 0.044f, 0.91f, false);
testLowCardinalityFiltering(32, 0.048f, 0.93f, true);
}
public void testLowCardinalityFiltering(int maxDegree, float visitedRatioThreshold, float recallThreshold, boolean addHierarchy) throws IOException {
var R = getRandom();

int nVectors = 100_000;
int nVectors = 10_000;
int nQueries = 100;
int dimensions = 16;
int topK = 10;
Expand Down