Allow compilation of the library using CMake #148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arcadien
commented
Jan 13, 2017
arcadien
commented
- Added CMakelists.txt control files
- Remove a QSharedPointer usage which bugs MSVC14
Added compatibility with Qt 5.6
Add CMake support for library and tests
Fix CMake 'install' target
More cmake-ization
Remove QSharedPointer probably incorrecy in xlxdocument
Nullpointer with this sequence:
1. Create new document
2. Insert at exceeding index (i.e. 1 with a new document)
3. Try to write to document
4. Crash while writing, because internal structure has wrong index.
'
QXlsx::Document xlsx(file_url);
if(!xlsx.insertSheet(1, "records")){
qDebug() << "Never here";
}
xlsx.write(1, 1, "id");
xlsx.save();'
NullPointer insertSheet with exceeding index fix
Synchronization with origin
…add histogram example file
* Debian-based Linux does not have any CMake files for Qt, and we rely on it for compilation (we are using private includes of Qt here). Script has been updated to add hardcoded pathes for these includes, echoing the needed package name.
remove static cache in col_to_name
daa20
reviewed
Oct 24, 2022
| endif() | ||
| if(${_qt_gui_include_dir} MATCHES "include/QtCore") | ||
| list(APPEND Qt5Gui_PRIVATE_INCLUDE_DIRS "${_qt_gui_include_dir}/${Qt5Core_VERSION}") | ||
| list(APPEND Qt5Gui_PRIVATE_INCLUDE_DIRS "${_qt_gui_include_dir}/${Qt5Core_VERSION}/QtCore") |
daa20
reviewed
Oct 24, 2022
| endif() | ||
| if(NOT Qt5Core_PRIVATE_INCLUDE_DIRS) | ||
| message("-- WARNING: No CMake setup for Qt 'Core' private part. You should need qtbase5-private-dev package") | ||
| list(APPEND Qt5Gui_PRIVATE_INCLUDE_DIRS "/usr/include/x86_64-linux-gnu/qt5/QtGui/5.5.1/QtCore/") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.