Skip to content

chore: inlining ms #1018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
+14 −4
Open

chore: inlining ms #1018

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
06f671d
inlining ms
hyperz111 Nov 7, 2025
7944066
remove ms
hyperz111 Nov 7, 2025
5a10e56
remove to hours
hyperz111 Nov 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,6 @@
"test:browser": "karma start --single-run",
"test:coverage": "cat ./coverage/lcov.info | coveralls"
},
"dependencies": {
"ms": "^2.1.3"
},
"devDependencies": {
"brfs": "^2.0.1",
"browserify": "^16.2.3",
Expand Down
15 changes: 14 additions & 1 deletion src/common.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ function setup(env) {
createDebug.disable = disable;
createDebug.enable = enable;
createDebug.enabled = enabled;
createDebug.humanize = require('ms');
createDebug.humanize = humanize;
createDebug.destroy = destroy;

Object.keys(env).forEach(key => {
Expand Down Expand Up @@ -284,6 +284,19 @@ function setup(env) {
console.warn('Instance method `debug.destroy()` is deprecated and no longer does anything. It will be removed in the next major version of `debug`.');
}

const s = 1000;
const m = s * 60;

function humanize(diff) {
if (diff >= m) {
return Math.round(diff / m) + 'm';
}
if (diff >= s) {
return Math.round(diff / s) + 's';
}
return diff + 'ms';
}

createDebug.enable(createDebug.load());

return createDebug;
Expand Down