Skip to content

fix(vmop): correct message for Completed condition for Pending vmop #1873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LopatinDmitr merged 2 commits into from
Jan 19, 2026
Merged

fix(vmop): correct message for Completed condition for Pending vmop #1873

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ed3f085
fix(vmop): correct message for Completed condition
LopatinDmitr Jan 14, 2026
c2ae619
fix(vmop): correct message for Completed condition
LopatinDmitr Jan 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 18 additions & 5 deletions images/virtualization-artifact/pkg/controller/vmop/migration/internal/handler/lifecycle.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -510,16 +510,29 @@ func isPodPendingUnschedulable(pod *corev1.Pod) bool {
return false
}

func (h LifecycleHandler) getConditionCompletedMessageByReason(ctx context.Context, reason vmopcondition.ReasonCompleted, mig *virtv1.VirtualMachineInstanceMigration) (string, error) {
msg := "Wait until operation is completed"
if reason == vmopcondition.ReasonMigrationPending || reason == vmopcondition.ReasonMigrationPrepareTarget {
func (h LifecycleHandler) getConditionCompletedMessageByReason(
ctx context.Context,
reason vmopcondition.ReasonCompleted,
mig *virtv1.VirtualMachineInstanceMigration,
) (string, error) {
switch reason {
case vmopcondition.ReasonMigrationPending:
return "The VirtualMachineOperation for migrating the virtual machine has been queued. " +
"Waiting for the queue to be processed and for this operation to be executed.", nil

case vmopcondition.ReasonMigrationPrepareTarget:
pod, err := h.getTargetPod(ctx, mig)
if err != nil {
return "", err
}

if isPodPendingUnschedulable(pod) {
msg += fmt.Sprintf(" (target pod is unschedulable: %s/%s)", pod.Namespace, pod.Name)
return fmt.Sprintf("Waiting for the virtual machine to be scheduled: "+
"target pod \"%s/%s\" is unschedulable.", pod.Namespace, pod.Name), nil
}
return "The target environment is in the process of being prepared for migration.", nil

default:
return "Wait until operation is completed.", nil
}
return msg + ".", nil
}
Loading