multi: Allow trezor ticket purchasing on testnet. #3848
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoeGruffins
force-pushed
the
trezorstake2
branch
from
aeb2590 to
37c28ca
Compare
JoeGruffins
force-pushed
the
trezorstake2
branch
from
37c28ca to
98d58d4
Compare
JoeGruffins
commented
Dec 28, 2022
JoeGruffins
force-pushed
the
trezorstake2
branch
2 times, most recently
from
3b6dbee to
520f67b
Compare
JoeGruffins
force-pushed
the
trezorstake2
branch
from
520f67b to
ab63ba0
Compare
JoeGruffins
force-pushed
the
trezorstake2
branch
2 times, most recently
from
30ef712 to
d39b95d
Compare
JoeGruffins
force-pushed
the
trezorstake2
branch
2 times, most recently
from
855810d to
83f0d64
Compare
Add purchaseTicketsV3 which purchases tickets using a watching only trezor wallet from a vsp with api v3. Errors if not on testnet. Add separate payVSPFee function that will pay a tickets fee if not already paid, and throws if already paid. Correct purchase ticket button for watching only wallets. It no longer asks for a password. Connect purchasing through trezor when isTrezor is true. Add vsp v3 endpoints "feeaddress" and "payfee" to allowed external requests. Change wallet/control.js to not require an unlocked wallet when signTx is false. Add headers to OPTIONS externalRequest. These are required by CORS when making POST requests.
JoeGruffins
force-pushed
the
trezorstake2
branch
from
83f0d64 to
9028a0b
Compare
This comment was marked as resolved.
This comment was marked as resolved.
|
Bump. Hardware wallet staking would be really cool to see. |
|
@matheusd Is there a reason this isn't being reviewed? |
|
What's the current status on this? Staking on trezor would be massive |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add purchaseTicketsV3 which purchases tickets using a watching only trezor wallet from a vsp with api v3. Errors if not on testnet.
Add separate payVSPFee function that will pay a tickets fee if not already paid, and throws if already paid.
Correct purchase ticket button for watching only wallets. It no longer asks for a password. Connect purchasing through trezor when isTrezor is true.
Add vsp v3 endpoints "feeaddress" and "payfee" to allowed external requests.
Change wallet/control.js to not require an unlocked wallet when signTx is false.
Add headers to OPTIONS externalRequest. These are required by CORS when making POST requests.
part of #2681
Should not be used with trezor v2.5.1 through v2.5.3 due to an unnoticed bug.