Skip to content

Conversation

@techgaun
Copy link

@techgaun techgaun commented Sep 24, 2025

Description

This moves accumulatedAudioData as a class variable and emitting data before thread is cleaned up. This seems to fix the issue. Also, removed the final read code in favor of using accumulatedAudioData

Closes #292

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Performance improvement
  • Refactoring

Architecture Decision

Test-Driven Development Checklist

Note: TDD is recommended but not required. The testing framework is newly available, and test coverage is being improved incrementally.

Pre-Implementation (for new features - recommended)

  • Architecture document created/updated
  • API design reviewed
  • Test plan created with test cases
  • Tests written before implementation (when feasible)

Implementation

  • TypeScript interfaces/types defined
  • iOS implementation complete
  • Android implementation complete
  • Web implementation complete (if applicable)

Testing

  • Unit tests included (recommended)
  • iOS platform tests pass
  • Android platform tests pass
  • Integration tests included (when applicable)
  • Cross-platform consistency verified
  • Test coverage adequate for the change
  • Edge cases and error scenarios considered
  • Performance impact measured (if applicable)

Test Evidence

# Test output (if applicable)
./scripts/run_tests.sh all
...

Documentation

  • API documentation updated
  • Usage examples added (if new feature)
  • CHANGELOG.md updated
  • README updated (if needed)

Breaking Changes

Related Issues

Checklist

  • My code follows the project's style guidelines
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • Tests are included (recommended for new features and bug fixes)
  • Existing tests pass locally with my changes
  • Any dependent changes have been merged and published

Screenshots/Videos

Additional Notes

@techgaun techgaun changed the title feat: properly emit final chunk of audio data feat: properly emit final chunk of audio data in android Sep 24, 2025
@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Android Only - Invalid Audio Stream Emitted If Stopped Before Hitting Interval Point

1 participant