Skip to content

Conversation

@aaronrockmenezes
Copy link
Collaborator

Description

Fix #(issue)

Type of change

Please check the option that is related to your PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
    • In this case, we recommend to discuss your modification on GitHub issues before creating the PR
  • Documentations (modification for documents)

Checklist

  • Run yapf -i <modified file> and check no errors
  • Run flake8 <modified file> --count and check no errors
  • Run mypy -p deepchem_server and check no errors
  • Run mypy -p py-ds and check no errors
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New unit tests pass locally with my changes
  • I have checked my code and corrected any misspellings

from ase.io import lammpsdata
import time


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aaronrockmenezes Make sure to add this to rst docs. Coordinate with @vsaravind01 on which rst files. I want a documentation structure similar to DeepChem where the docs provide scientific comment.

We should add a primitives.rst file as a first cut

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants