Upgrade support to TF 2.10 #901
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the oldest version with arm64 builds, enabling spleeter to work on arm64 Linux. We need to pin numpy to <2.0 to avoid incompatibilities, and also drop Python 3.7 support to make sure we get new enough versions of numpy and scipy.
marcan
requested review from
Faylixe,
alreadytaikeune,
mmoussallam and
romi1502
as code owners
|
Really Love This PR! You saved me again marcan! Respect! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade to TF 2.10
Description
This is the oldest version with arm64 builds, enabling spleeter to work on arm64 Linux. We need to pin numpy to <2.0 to avoid incompatibilities, but we also need new enough versions for the TF 2.10 builds to work. This in turn requires dropping Python 3.7 support (which is very old at this point).
This also upgrades mypy to 0.991 since the old version runs into a broken version of the typed-ast dependency on Python 3.10.
How this patch was tested
Tested on an ARM64 M1 Pro MacBook Pro running Fedora Asahi Remix in a Python3.10 venv, running the tests with
poetry run pytest tests/as well as a simple usage test ofspleeter.poetry run pytest tests/poetry run black spleeter