WIP: Allow subclassing MultipartSegment #74
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch includes refactoring and changes of internal APIs to allow stabilizing those APIs in the future.
Owner
Author
|
See #77 for a new approach |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow use of the core parsing functionality for other use cases (e.g.
multipart/byterangeas described in #73) by allowing users to subclassMultipartSegment.This is a WIP. First step was to clean up the API between
PushMultipartParserandMultipartSegmentto make it easier to hook into those APIs. The newMultipartSegment._on_*methods are still private APIs and may change between releases, so be careful. But it looks nice now, so future changes should be less likely.One idea was to split the segment class into
MultipartSegmentBaseimplementing universal parsing logic only, andMultipartSegmentimplementing the additional checks and logic for form-data segments. I tried that, but it reduced throughput by up to 5% in some tests and made documentation more complicated. I'm not sure if I really want that, but it's not from the table just yet.