Merged
Conversation
Sean329
approved these changes
Feb 25, 2025
jrhea
reviewed
Feb 25, 2025
jrhea
reviewed
Feb 25, 2025
jrhea
reviewed
Feb 25, 2025
There was a problem hiding this comment.
This is great work! Ideally, it would be good to have the following tests:
- migrate pre-cliff, (attempt) claim pre-cliff
- migrate pre-cliff, claim post-cliff, pre-expiration
- migrate pre-cliff, claim post-expiration
- migrate post-cliff, pre-expiration, claim pre-expiration
- migrate post-cliff, pre-expiration, claim post-expiration
- migrate post-expiration, claim post-expiration
to verify that all the logic works as expected. Wdyt?
jrhea
reviewed
Feb 25, 2025
jrhea
reviewed
Feb 25, 2025
jrhea
reviewed
Feb 25, 2025
jrhea
reviewed
Feb 25, 2025
jrhea
approved these changes
Feb 25, 2025
jrhea
left a comment
There was a problem hiding this comment.
approved! just a couple of additional nits
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the
MigrationRewardsVault. This vault locks the depositor's ELFI for 3 months and then unlocks a 5% APR bonus over the following two months. If users migrate after the cliff, their bonus period will start later, and they will receive a smaller bonus than if they had locked their ELFI earlier. Once the users claim their HD tokens, they stop receiving a bonus.