fix: replaced luminance threshold constant 0.03928 with 0.04045 #4934
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
WilcoFiers
changed the title
WilcoFiers
changed the title
WilcoFiers
approved these changes
Nov 10, 2025
Contributor
WilcoFiers
left a comment
WilcoFiers
left a comment
There was a problem hiding this comment.
Looks good to me. Thank you for the contribution @AdminAdi
For the books: I reviewed this PR for security.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #4933
Updates the luminance calculation constant from 0.03928 to 0.04045 in lib/commons/color/get-contrast.js to align with the corrected WCAG 2.2 standard. While the practical impact on contrast ratios is minimal, this change ensures standards compliance with the current WCAG guidelines.