Update for Symphony 4.x #21
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Symphony 4.x ? Is that correct? |
Collaborator
|
@designermonkey yes!! |
Owner
|
@nitriques I can't find that version on the symphony github repo :/ Any pointers as to where it is? |
Collaborator
added 12 commits
December 12, 2018 11:36
Update release version. Update layout to fit in with Symphony 4.x. Wrap Geobuttons in div instead of label to fix hover. Remove console.logs from js.
PHP true,false,null in lowercase SQL keywords uppercase
Owner
|
I know I've been an absentee owner of Symphony CMS for some time now, sadly due to contractual obligations not allowing me to work on OSS projects, but I have a concern here... I'm not happy to merge commits that relate to a project that is not hosted at the core repository. I know @nitriques that you've looked after this repo for a long while now, but still, I am unhappy with this; not because of the quality, but because Symphony 4 is not part of the organisation. I would love to get back involved in the project, unfortunately contract says no :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update release version.
Update layout to fit in with Symphony 4.x.
Wrap Geobuttons in div instead of label to fix hover.
Remove console.logs from js.