-
Notifications
You must be signed in to change notification settings - Fork 50
#1562: update dokumentation regarding environmental variables #1697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#1562: update dokumentation regarding environmental variables #1697
Conversation
update Variables table
Add new variables to the table
Add link to an Interface that defines all the available variables
Pull Request Test Coverage Report for Build 21512683408Details
💛 - Coveralls |
SDallmann
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Were the examples for «TOOL»_VERSION and «TOOL»_EDITION intentionally removed?
Other than that, everything looks good to me 👍
Thanks for your review! Since these examples cannot contain exact values because they depend on the tool in question , it was decided to leave them empty |
hohwille
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lubska thanks for your PR. You went through all variables and added example values. 👍
Only after reviewing the documentation I remembered that we provide the default value here (if defined in IdeVariables) or otherwise given an reasonable example with an i.e. prefix.
I added some constructive review comments that you can apply (in diff you as a batch in one commit).
Then we can merge your PR.
Co-authored-by: Jörg Hohwiller <[email protected]>
…garding-environmental-Variables
hohwille
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lubska thanks for the update and conflict resolution. You did all correct 👍
Unfortunately I missed one little detail in my first review.
We can submit/apply that suggestion and then finally merge.
This PR fixes #1562
Implemented changes:
update dokumentation regarding environmental variables:
updates Variables table in Documentation
adds new variables to the table
adds link to an Interface that defines all the available variables
Checklist for this PR
Make sure everything is checked before merging this PR. For further info please also see
our DoD.
mvn clean testlocally all tests pass and build is successful#«issue-id»: «brief summary»(e.g.#921: fixed setup.bat). If no issue ID exists, title only.In Progressand assigned to you or there is no issue (might happen for very small PRs)with
internal