Skip to content

Conversation

@songhuaixu
Copy link
Contributor

No description provided.

Copy link
Owner

@dfed dfed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a reasonable addition once it's compiling.

I think it'd make sense to add this name parameter to the Task initializers below as well, so that each individual task (not just the top-level queue) can be named.

@dfed
Copy link
Owner

dfed commented Nov 28, 2025

Good improvements. Not sure why CI is still failing. Might be Swift 6.0 vs 6.2? I'm on mobile today so not sure. Can look closer tomorrow if you're stuck. Let me know!

@songhuaixu
Copy link
Contributor Author

songhuaixu commented Nov 28, 2025

It seems to be an issue with Xcode 16. My Xcode 26 here is working fine

It might be due to an error in the method signature caused by adding a name in Xcode 16

@dfed
Copy link
Owner

dfed commented Nov 28, 2025

Looks like the name property was introduced in Swift 6.2, which is why we're not compiling on Swift 6.0. I'm down to do a version bump to get us on minimum version 6.2 to support this, but no promises that I'll get to that this week. Will merge this in once I drop Swift 6.0/6.1 (and therefore Xcode 16.*) support.

@songhuaixu
Copy link
Contributor Author

But Task init name has long supported it

@dfed
Copy link
Owner

dfed commented Nov 28, 2025

I see that the method exists on older operating systems. But I don't see the init(name: API when I look up the Task init I'm Seift 6.1 on Xcode 16.4.

It seems like this initializer was backported? I'm struggling to come up with an alternative.

@codecov
Copy link

codecov bot commented Nov 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (79533e0) to head (c29dc72).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##              main       #61   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           13        13           
  Lines         1301      1301           
=========================================
  Hits          1301      1301           
Files with missing lines Coverage Δ
Sources/AsyncQueue/ActorQueue.swift 100.00% <100.00%> (ø)
Sources/AsyncQueue/FIFOQueue.swift 100.00% <100.00%> (ø)
Sources/AsyncQueue/Utilities/Delivery.swift 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Owner

@dfed dfed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@dfed dfed merged commit 8e06d33 into dfed:main Nov 29, 2025
13 checks passed
@songhuaixu songhuaixu deleted the task_name branch November 29, 2025 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants