feat(outcalls): add price_version parameter to the http canister request args #7447
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mraszyk
reviewed
Oct 29, 2025
Contributor
kpop-dfinity
left a comment
kpop-dfinity
left a comment
There was a problem hiding this comment.
Left some comments mostly about the choices between returning errors vs returning default values
mraszyk
approved these changes
Oct 29, 2025
Contributor
mraszyk
left a comment
mraszyk
left a comment
There was a problem hiding this comment.
I'm approving this PR since the code owned by the execution team is correct (as far as I can see) and my suggestion regarding using an enumeration instead of integers in the public API is a design concern that should have been caught earlier in the process (and thus it is not blocking at this stage).
kpop-dfinity
approved these changes
Oct 30, 2025
Contributor
kpop-dfinity
left a comment
kpop-dfinity
left a comment
There was a problem hiding this comment.
LGTM with some nits
Co-authored-by: kpop-dfinity <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the price version, as described in dfinity/portal#6101 to the management canister
http_requestendpoint.This PR also persists the version in the replicated state. In the future that will be used to determine which pricing strategy should be applied.
The flag is a candid opt nat32, which, if missing, defaults to "1", which corresponds to the "current" pricing. Similarly, if set to "2", the flag will default back to 1, as version 2 is not implemented yet.
In the future, we will support pricing_Version = 2, which corresponds to the "pay-as-you-go" pricing.