-
Notifications
You must be signed in to change notification settings - Fork 562
Promote Drift to CE #2334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Promote Drift to CE #2334
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should get rid of this entire package I believe it has all moved to ce
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i left it as a thin wrapper on purpose (main.go as it was, the rest imported from CE) - so that the "EE build" contains all the same components as CE build (backend svc, cli, drift svc). this way an EE user would have a consistent package, and it leaves room for future EE-only features in the drift svc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in the limit of complete EE = CE parity I think we'd still want a separate entry point for each EE component, even if they are functionally identical
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lowercase file name better to be consistent with all others
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed!
This promotes Drift functionality from EE to CE
Tested, working: https://github.com/diggerhq/test-drift-ce/issues/1
In
ee/backend, imports ofgithub.com/diggerhq/digger/ee/drift/middlewarereplaced withgithub.com/diggerhq/digger/backend/middleware.🧠 AI Assistance Disclosure Policy
Important
Inspired by ghostty.
If you used any AI assistance while contributing to Digger, you must disclose it in this PR.
✅ AI Disclosure Checklist
Details (if applicable):
💡 Notes