Fix copy tweet links setting #1175
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix cancel handling to restore previous value when prompt is cancelled - Add display of custom domain value next to the select dropdown - Properly update select state when custom value is saved - Add vars.copyLinksAs update (note: still requires page reload to take effect)
Read copyLinksAs directly from storage when copying links instead of using cached vars value. This ensures the setting takes effect immediately across all pages without requiring a page reload. - Update copy link handlers in tweetviewer.js and helpers.js to read from chrome.storage.sync - Fallback to vars.copyLinksAs or 'twitter.com' if storage read fails - Fixes limitation mentioned in previous commit where page reload was required
Remove verbose cancellation handling and unnecessary defensive checks. Simplify variable naming to avoid shadowing in copy link handlers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the “copy links as” preference was read from a cached variable, so users had to refresh the page to see a change.
This patch makes
scripts/tweetviewer.jsandscripts/helpers.jsfetch the value directly from storage every time a user copies a link, guaranteeing the latest setting is used even on cached pages.I also added a small text display next to the dropdown to show what custom value/site you have set; previously the only indicator was the ambiguous “custom” label in the dropdown.