Skip to content

Conversation

@raifdmueller
Copy link

This PR enhances the deep-dive-solution.adoc file with more comprehensive AsciiDoc examples as requested in issue #4.

Enhancements

  • Advanced table formatting

    • Added examples for column spans, row spans, and text alignment
    • Included CSV tables and auto-width tables
    • Added tables with custom column styles (AsciiDoc, monospace, strong)
  • More diagram types

    • Enhanced PlantUML examples with sequence and component diagrams
    • Added a C4 architecture diagram example
    • Added Mermaid and Graphviz diagram examples
    • Demonstrated Kroki.io integration
  • AsciiDoc extensions and macros

    • Added UI macros (buttons, menus, keyboard shortcuts)
    • Included footnotes and indexing terms
    • Added custom macro examples
  • Cross-referencing

    • Demonstrated internal section references with IDs
    • Added guidelines for effective cross-referencing
  • Conditional content inclusion

    • Added examples for conditional content based on attributes
    • Showed how to use ifdef/ifndef directives
  • Advanced formatting features

    • Added callouts for multiple languages
    • Included sidebar and example blocks
    • Demonstrated collapsible blocks
    • Added custom styling via roles
  • Document structuring best practices

    • Provided guidelines for document organization
    • Included optimization tips for better documentation
    • Added examples of effective use of attributes
  • Mathematical notation

    • Added examples for inline and block math formulas using STEM notation

Each feature includes explanations about when and why to use it, following the acceptance criteria. The examples are functional and well-documented, following AsciiDoc best practices.

Testing

The examples have been tested for correct AsciiDoc syntax and rendering.

Fixes #4

This commit adds more comprehensive AsciiDoc examples to the deep-dive-solution.adoc file, addressing issue docToolchain#4. Enhancements include:

- Advanced table formatting (with column spans, row spans, alignment)
- More diagram types (sequence diagrams, component diagrams, mermaid, graphviz)
- AsciiDoc extensions and macros
- Cross-referencing between documents
- Conditional content inclusion
- Advanced formatting with callouts and sidebars
- Document structuring best practices
- Tips for optimizing AsciiDoc documents
- Math notation examples
- Collapsible blocks
- Custom styling via roles

Each section includes practical examples with explanations of when and why to use specific features.
@raifdmueller
Copy link
Author

Hi @rdmueller,

I've created this PR to address issue #4. The enhanced deep-dive-solution.adoc file now includes comprehensive examples of AsciiDoc's more advanced features, with explanations of when and why to use them.

The document is structured to serve as both a reference and a learning resource for workshop participants. Each section builds on the previous ones, starting with basic formatting and progressing to more advanced topics.

Key improvements:

  1. Added extensive table formatting examples including spans and alignment
  2. Included various diagram types (PlantUML, Mermaid, Graphviz, C4)
  3. Added cross-referencing examples with best practices
  4. Included conditional content examples
  5. Added advanced formatting features like sidebars and callouts
  6. Provided document structuring best practices and optimization tips
  7. Included mathematical notation examples
  8. Added UI macros and extensions

All examples are fully functional and follow AsciiDoc best practices. Let me know if you'd like any adjustments!

@rdmueller rdmueller requested a review from Copilot May 21, 2025 13:07
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances the documentation by adding comprehensive AsciiDoc examples and updates the installation instructions to include Java as a prerequisite.

  • Introduces ./dtcw install java in the README to ensure a local JDK is available before installing the DocToolchain.
  • (Other changes to deep-dive-solution.adoc are described in the PR metadata.)

----
curl -Lo dtcw doctoolchain.github.io/dtcw
chmod +x dtcw
./dtcw install java
Copy link

Copilot AI May 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding a brief note explaining that this step installs a local JDK required by DocToolchain.

Suggested change
./dtcw install java
./dtcw install java
// This step installs a local JDK, which is required for DocToolchain to function.

Copilot uses AI. Check for mistakes.

AsciiDoc automatically handles:

* Typographic quotes: "curly quotes" (instead of "straight quotes")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sollten hier und in den folgenden Zeilen die AsciiDoc-Beispiele nicht escaped werden?


[cols="1,2,3", options="header"]
|===
|Column 1 (10%)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stimmt das so mit den Prozentangaben?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enhance deep-dive-solution.adoc with more AsciiDoc examples

2 participants