Add bake definition #567
Open
Add bake definition #567
+282
−169
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crazy-max
force-pushed
the
bake
branch
7 times, most recently
from
fb3a92f to
fbd52a6
Compare
crazy-max
force-pushed
the
bake
branch
4 times, most recently
from
e3f295b to
d7a9ec7
Compare
Signed-off-by: CrazyMax <[email protected]>
Also rename cross stage to binaries. cross does not make sense as name as the output is based on target platforms. Signed-off-by: CrazyMax <[email protected]>
Signed-off-by: CrazyMax <[email protected]>
Signed-off-by: CrazyMax <[email protected]>
Signed-off-by: CrazyMax <[email protected]>
Signed-off-by: CrazyMax <[email protected]>
Signed-off-by: CrazyMax <[email protected]>
Signed-off-by: CrazyMax <[email protected]>
Signed-off-by: CrazyMax <[email protected]>
Signed-off-by: CrazyMax <[email protected]>
Signed-off-by: CrazyMax <[email protected]>
Signed-off-by: CrazyMax <[email protected]>
Signed-off-by: CrazyMax <[email protected]>
Signed-off-by: CrazyMax <[email protected]>
Signed-off-by: CrazyMax <[email protected]>
Signed-off-by: CrazyMax <[email protected]>
Signed-off-by: CrazyMax <[email protected]>
Signed-off-by: CrazyMax <[email protected]>
crazy-max
commented
Oct 27, 2025
| assert.NotNil(t, db, "Database should be created successfully") | ||
|
|
||
| // Test with invalid path | ||
| _, err := NewMemoryDatabase("/:invalid:path") |
There was a problem hiding this comment.
/:invalid:path is technically valid:
#18 6.407 --- FAIL: TestNewMemoryDatabase (0.05s)
#18 6.407 sqlite_test.go:43:
#18 6.407 Error Trace: /src/pkg/memory/database/sqlite/sqlite_test.go:43
#18 6.407 Error: An error is expected but got nil.
#18 6.407 Test: TestNewMemoryDatabase
#18 6.407 Messages: Should fail with invalid database path
#18 6.407 FAIL
rumpl
reviewed
Oct 28, 2025
| @@ -1,6 +1 @@ | |||
| * | |||
There was a problem hiding this comment.
@dgageot prefers the "Ignore everything first and then add things that are needed one by one"
rumpl
reviewed
Oct 28, 2025
| test: | ||
| desc: Run tests | ||
| cmd: go test ./... | ||
| sources: |
There was a problem hiding this comment.
Why did you remove the sources? Is this even needed now that we have the bake target, or maybe this should just call bake?
rumpl
reviewed
Oct 28, 2025
| @@ -1,6 +1,6 @@ | |||
| module github.com/docker/cagent | |||
|
|
|||
| go 1.25.3 | |||
There was a problem hiding this comment.
I'm sure there is a completely valid reason, I would just like to know why please :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First containerized most of the tasks to avoid drifting with external tooling like golangci-lint, go version and so on.
Adds bake definition so we can avoid arbitrary targets from Taskfile and be consistent and repro between inner loop and ci environment. Here is a breakdown of the changes:
localstage in the Dockerfile has been removed since we now create non opinionated binary name.releaserstage has been added to create proper release artifacts if we want to upload them as GitHub Releases in the future.binariesif no target is specifiedvalidatetarget group runslint,testandlicensesimageandimage-crossbuild the cagent imagereleasetarget does a cross-build of the binaries and output release artifacts to./bin/releasebinariesandbinaries-crossbuild binaries and output to./bin/buildtestrun go test with coverage and output coverage result to./bin/coveragethat could then be uploaded to codecov if we want to, like we do for other projects https://app.codecov.io/gh/dockerlicensesruns go-licenses in a containerized env without need to install the binary.lintruns golangci-lint also in a containerized env without need to install the binary.