Fix stream cancellation in the TUI #600
Merged
+103
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rumpl
reviewed
Oct 24, 2025
| ScrollToBottom() tea.Cmd | ||
| AddShellOutputMessage(content string) tea.Cmd | ||
| AddSystemMessage(content string) tea.Cmd | ||
| RemoveSpinner() |
There was a problem hiding this comment.
Instead of making this public it would be nicer maybe to have a command that is sent down to all the components that tell them that the stream is cancelled, WDYT? Just asking
There was a problem hiding this comment.
Agree, I changed this
Also adds a message indicating that the stream has been canceled Signed-off-by: Christopher Petito <[email protected]>
krissetto
force-pushed
the
fix-stream-cancelation-tui
branch
from
f157d62 to
b70d802
Compare
rumpl
approved these changes
Oct 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes stream cancellation logic in the TUI by stopping and removing all spinners, allowing the user to send followup messages, and adds a message indicating to the user that the stream has been canceled
Screenshot
Closes #597