vendor: github.com/moby/moby/api, moby/moby/client master #6571
+4,457
−3,363
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Really WIP right now. |
thaJeztah
force-pushed
the
bump_modules
branch
7 times, most recently
from
0b13cd7 to
cb96562
Compare
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
thaJeztah
force-pushed
the
bump_modules
branch
6 times, most recently
from
bac2521 to
989b978
Compare
Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
changed the title
Some tests had to be skipped as there's some issues to address, and some of the result-types cannot be mocked / stubbed. Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
bump_modules
branch
from
989b978 to
4f7c07c
Compare
|
I kept it as two commits, because otherwise GitHub won't render (other than 1 file at a time). Some tests had to be skipped, because there's some bugs, and some result types could not be stubbed / mocked currently. |
thaJeztah
commented
Oct 24, 2025
| } | ||
| return client.ImagePullResponse{}, nil | ||
| // FIXME(thaJeztah): how to mock this? | ||
| return nil, nil |
There was a problem hiding this comment.
We need to look at these, as there's no concrete types to use for mocking / testing
thaJeztah
commented
Oct 24, 2025
Comment on lines
-58
to
+57
| return io.NopCloser(strings.NewReader("")), nil | ||
| // FIXME(thaJeztah): how to mock this? | ||
| return nil, nil |
thaJeztah
commented
Oct 24, 2025
Comment on lines
52
to
+53
| } | ||
|
|
||
| func TestNewImportCommandSuccess(t *testing.T) { | ||
| t.Skip("FIXME(thaJeztah): how to mock this?") |
There was a problem hiding this comment.
Added a few skips for now that must be removed once we have a solution
vvoland
approved these changes
Oct 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
- How I did it
- How to verify it
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)