image/list: Hide untagged images without --all
#6574
+33
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
vvoland
commented
Oct 24, 2025
| } | ||
| images := res.Items | ||
| if !options.all { | ||
| if _, ok := filters["dangling"]; ok { |
There was a problem hiding this comment.
Not 100% sure about this, but I think it makes sense to NOT manipulate the dangling images if --all wasn't passed but dangling filter was used explicitly
There was a problem hiding this comment.
Not at my computer to test, but this means that filtering for dangling images won't produce a result unless --all is also passed? Or is this just the optimization to not process them?
There was a problem hiding this comment.
Yes, without this change docker images --filter dangling=true would always result in empty image list.
thaJeztah
reviewed
Oct 24, 2025
The `--tree` implementation already does this. Make the behavior consistent for the legacy image list implementation. Signed-off-by: Paweł Gronowski <[email protected]>
Otherwise `docker images --filter dangling=true` won't work without `--all`. Signed-off-by: Paweł Gronowski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
--treeimplementation already does this.Make the behavior consistent for the legacy image list implementation.
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)