Introduce abstractions to support SDK usage without requiring Docker CLI #13313
+294
−36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glours
force-pushed
the
prep-sdk-support
branch
from
00eb147 to
0ed82f9
Compare
This commit prepares the Compose service for SDK usage by abstracting away the hard dependency on command.Cli. The Docker CLI remains the standard path for the CLI tool, but SDK users can now provide custom implementations of streams and context information. Signed-off-by: Guillaume Lours <[email protected]>
glours
force-pushed
the
prep-sdk-support
branch
from
0ed82f9 to
a4a48cc
Compare
…d transparently returns custom streams when provided via options Add new Stdout, Stdin and Stderr to Compose API definition Signed-off-by: Guillaume Lours <[email protected]>
glours
force-pushed
the
prep-sdk-support
branch
from
9b508a2 to
68887ae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit prepares the Compose service for SDK usage by abstracting away the hard dependency on command.Cli. The Docker CLI remains the standard path for the CLI tool, but SDK users can now provide custom implementations of streams and context information.
What I did
NewComposeServiceRelated issue
#13230
(not mandatory) A picture of a cute animal, if possible in relation to what you did
