add-no-store-instruction-header: Add no store instruction for cache header #49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
papey
changed the title
papey
force-pushed
the
replace-cache-header-instruction-with-no-store
branch
from
2d3d99f to
19db94c
Compare
marlosin
reviewed
Feb 3, 2025
| assert_headers(headers, [ | ||
| {"access-control-allow-origin", "*"}, | ||
| {"cache-control", "no-cache"}, | ||
| {"cache-control", "no-cache, no-store"}, |
There was a problem hiding this comment.
shall we do exactly as siiloSSE?
Suggested change
| {"cache-control", "no-cache, no-store"}, | |
| {"cache-control", "no-cache, no-store, max-age=0, must-revalidate"}, |
achouippe
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
We don't want any cache mechanism on requests that contains sensitive data
Changes
Added cache header instruction no-store, see related MDN documentation