Skip to content

Conversation

@achouippe
Copy link
Contributor

@achouippe achouippe commented Feb 12, 2025

This PR brings minor changes to SSE subscription to prevent browsers from automatically trying to reconnect with their previous authenticated headers after a long inactivity period:

  • Support both GET and POST http methods - this should be temporary to allow clients to migrate to HTTP posts, then get support should be removed
  • Add extra cache directives.

@achouippe achouippe marked this pull request as ready for review February 12, 2025 15:43
Copy link
Member

@papey papey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, covering the overlap of get and post 👍

@achouippe achouippe merged commit 7f43ab0 into main Feb 12, 2025
5 checks passed
@achouippe achouippe deleted the subscribe-with-post branch February 12, 2025 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants