Skip to content

Conversation

@taraszka
Copy link
Contributor

@taraszka taraszka commented Apr 9, 2024

Same story as #45 - the Dockerfile specifies either ENTRYPOINT or CMD

@josegonzalez
Copy link
Member

Actually this and the other PR seems backwards - we extract the command in the same manner the docker-local one extracts commands and set them. That allows us to support Procfile for both this and pack.

Code for that is here: https://github.com/dokku/dokku-scheduler-kubernetes/blob/master/internal-functions#L756-L774

@taraszka
Copy link
Contributor Author

taraszka commented Apr 9, 2024

Are you sure? Without Procfile, it complains that Procfile is not found and refuses to deploy to Kubernetes using this legacy scheduler. I have tried with both pack and dockerfile builders. I haven't yet tried with nix.

@josegonzalez
Copy link
Member

So that sounds like a bug in the code that extracts the Procfile, maybe not correctly ported from the docker-local logic. Do you have log output for that?

@taraszka
Copy link
Contributor Author

Ok, I will have a look, thanks. Need to redeploy an app to capture the log output.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants