Fixed some bugs for Pack compression, pack file service and shares Content folder generation. Also tidied up game info. #265
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixed issue where pack file compression wasn't working with files not yet a PackedFileSource, sped up file saving, and improved compression format determination. - Made broken files show as a warning regardless of whether the debugger is attached as before it would show the message either way, but as an error in the release build, and warning in the debug build.
- Made the Content folder be included in the publish directory.
- Removed unused game settings stuff and implemented for Ole's convert to dictionary comment. - Fixed an issue where finding pack file paths was failing to find paths when given a different instance with the same name. - Fixed an issue where the pack file browser window wasn't getting the folder correctly. - Fixed ImportDirectoryCommand to import from the selected folder with full subdirectory structure. - Added some compresion comments.
Pear-231
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bugs detailed in commits. Tidied up game info as it was getting unwieldy with the added audio info so make it into a dictionary like Ole's comment suggested to do.