Skip to content

Add Namespace table to BAR #5575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Nov 27, 2025
Merged

Add Namespace table to BAR #5575

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
ddaa7fa
Make the db model changes
dkurepa Nov 25, 2025
00ded27
Finalize db look, migration file, update API and models
dkurepa Nov 25, 2025
fbb79ca
Make tests green
dkurepa Nov 26, 2025
0305755
Regenerate the PCS Client
dkurepa Nov 26, 2025
07d10d6
fix model namespace
dkurepa Nov 26, 2025
8258e25
remove sln
dkurepa Nov 26, 2025
697257b
Cleanup stuff
dkurepa Nov 26, 2025
35ee76e
Merge remote-tracking branch 'source/main' into dkurepa/AddNamespaceT…
dkurepa Nov 26, 2025
2a14202
Remove namespace from API models, set a default namespace in all API …
dkurepa Nov 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 38 additions & 8 deletions src/Maestro/Maestro.Data/BuildAssetRegistryContext.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,13 +22,6 @@ public BuildAssetRegistryContext CreateDbContext(string[] args)
{
var connectionString = GetConnectionString("BuildAssetRegistry");

var envVarConnectionString = Environment.GetEnvironmentVariable("BUILD_ASSET_REGISTRY_DB_CONNECTION_STRING");
if (!string.IsNullOrEmpty(envVarConnectionString))
{
Console.WriteLine("Using Connection String from environment.");
connectionString = envVarConnectionString;
}

DbContextOptions options = new DbContextOptionsBuilder()
.UseSqlServerWithRetry(connectionString, opts =>
{
Expand All @@ -41,7 +34,16 @@ public BuildAssetRegistryContext CreateDbContext(string[] args)

public static string GetConnectionString(string databaseName)
{
return $@"Data Source=localhost\SQLEXPRESS;Initial Catalog={databaseName};Integrated Security=true;Encrypt=false"; // CodeQL [SM03452] This 'connection string' is only for the local SQLExpress instance and has no credentials, Encrypt=false for .NET 8+ compatibility
var connectionString = $@"Data Source=localhost\SQLEXPRESS;Initial Catalog={databaseName};Integrated Security=true;Encrypt=false"; // CodeQL [SM03452] This 'connection string' is only for the local SQLExpress instance and has no credentials, Encrypt=false for .NET 8+ compatibility
Copy link
Member

@premun premun Nov 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this method be rather like this?

if (!string.IsNullOrEmpty(envVarConnectionString))
  connectionString = $@"..";
else
  connectionString = envVarConnectionString;

var envVarConnectionString = Environment.GetEnvironmentVariable("BUILD_ASSET_REGISTRY_DB_CONNECTION_STRING");
if (string.IsNullOrEmpty(envVarConnectionString))
{
return connectionString;
}
else
{
return envVarConnectionString;
}
}
}

Expand All @@ -64,6 +66,7 @@ public class BuildAssetRegistryContext(DbContextOptions options)
public DbSet<DependencyFlowEvent> DependencyFlowEvents { get; set; }
public DbSet<GoalTime> GoalTime { get; set; }
public DbSet<LongestBuildPath> LongestBuildPaths { get; set; }
public DbSet<Namespace> Namespaces { get; set; }

public virtual IQueryable<RepositoryBranchUpdateHistoryEntry> RepositoryBranchUpdateHistory => RepositoryBranchUpdates
.TemporalAll()
Expand Down Expand Up @@ -259,6 +262,33 @@ protected override void OnModelCreating(ModelBuilder builder)
.WithMany()
.HasForeignKey(gt => gt.ChannelId);

builder.Entity<Namespace>()
.HasKey(n => n.Id);

builder.Entity<Namespace>()
.HasIndex(n => n.Name)
.IsUnique();

builder.Entity<Subscription>()
.HasOne(s => s.Namespace)
.WithMany(n => n.Subscriptions)
.OnDelete(DeleteBehavior.Restrict);

builder.Entity<Channel>()
.HasOne(c => c.Namespace)
.WithMany(n => n.Channels)
.OnDelete(DeleteBehavior.Restrict);

builder.Entity<RepositoryBranch>()
.HasOne(rb => rb.Namespace)
.WithMany(n => n.RepositoryBranches)
.OnDelete(DeleteBehavior.Restrict);

builder.Entity<DefaultChannel>()
.HasOne(dc => dc.Namespace)
.WithMany(n => n.DefaultChannels)
.OnDelete(DeleteBehavior.Restrict);

builder.HasDbFunction(() => JsonExtensions.JsonValue("", ""))
.HasTranslation(args => new SqlFunctionExpression(
"JSON_VALUE",
Expand Down
Loading