Skip to content

Conversation

@joperezr
Copy link
Member

Copilot AI review requested due to automatic review settings December 17, 2025 17:09
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR upgrades the eShop application from Aspire 13.0 to Aspire 13.1, along with related dependency updates. The upgrade affects the .NET Aspire hosting SDK, Aspire component packages, Microsoft Extensions libraries, ASP.NET Core packages, Entity Framework tools, and OpenTelemetry instrumentation packages. This appears to be a routine maintenance update to keep the application aligned with the latest stable releases of the Aspire framework and its associated dependencies.

Key changes:

  • Aspire framework upgraded from 13.0.x to 13.1.0 (SDK and package versions)
  • Microsoft Extensions libraries updated from 10.0.0 to 10.1.0
  • ASP.NET Core packages updated from 10.0.0 to 10.0.1
  • OpenTelemetry packages updated from 1.12.0 to 1.14.0

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
src/eShop.AppHost/eShop.AppHost.csproj Updates the Aspire.AppHost.Sdk from version 13.0.0 to 13.1.0
Directory.Packages.props Updates centrally managed package versions for Aspire (13.0.1→13.1.0), Microsoft Extensions (10.0.0→10.1.0), ASP.NET Core packages (10.0.0→10.0.1), Entity Framework Tools (10.0.0→10.0.1), Runtime packages (10.0.0→10.0.1), and OpenTelemetry packages (1.12.0→1.14.0)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

<PropertyGroup>
<ManagePackageVersionsCentrally>true</ManagePackageVersionsCentrally>
<CentralPackageTransitivePinningEnabled>true</CentralPackageTransitivePinningEnabled>
<AspnetVersion>10.0.0</AspnetVersion>
Copy link

Copilot AI Dec 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The AspnetVersion property is still set to 10.0.0, but all ASP.NET packages have been updated to 10.0.1 (lines 36-45). While the property is not currently used anywhere, consider updating it to 10.0.1 to maintain consistency with the actual ASP.NET package versions, or remove it if it's no longer needed.

Suggested change
<AspnetVersion>10.0.0</AspnetVersion>
<AspnetVersion>10.0.1</AspnetVersion>

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants