[iOS, Catalyst] Fixed CollectionView items height appears larger in Developer Balance sample #31902
Conversation
|
Hey there @@karthikraja-arumugam! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
dotnet-policy-service
bot
added
the
partner/syncfusion
There was a problem hiding this comment.
Pull Request Overview
This pull request fixes a layout issue in CollectionView where cards appeared larger than expected on iOS and Mac platforms. The issue was caused by incorrect sizing behavior when content size wasn't initially available.
Key changes:
- Modified the sizing logic to consider CollectionView orientation when determining content size
- Added scroll direction awareness to prevent incorrect sizing in horizontal layouts
- Included comprehensive UI tests to validate the fix
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/Controls/src/Core/Handlers/Items2/ItemsViewHandler2.iOS.cs |
Updated GetDesiredSize method to handle orientation-aware sizing logic |
src/Controls/src/Core/Handlers/Items2/iOS/ItemsViewController2.cs |
Added GetScrollDirection method to expose CollectionView orientation |
src/Controls/tests/TestCases.HostApp/Issues/Issue31897.cs |
Created UI test page with horizontal CollectionView to reproduce the issue |
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue31897.cs |
Added automated test to verify CollectionView height behavior |
karthikraja-arumugam
changed the title
|
@dotnet-policy-service agree company="Syncfusion, Inc." |
sheiksyedm
added
the
area-controls-collectionview
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
|
||
| [Test] | ||
| [Category(UITestCategories.CollectionView)] | ||
| public void EnsureCollectionViewLayoutOnItemsSourceChange() |
There was a problem hiding this comment.
Could expand the tests by setting different item sources and asserting layout change (e.g., when items are added/removed, does the height still reflect correctly?). This ensures future changes do not regress measurement logic.
There was a problem hiding this comment.
@jsuarezruiz, New test scenarios were included. Could you please review and let me know if any concerns?
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/backport to release/10.0.1xx |
|
Started backporting to release/10.0.1xx: https://github.com/dotnet/maui/actions/runs/18596704471 |
github-project-automation
bot
moved this from Ready To Review
to Approved
in MAUI SDK Ongoing
|
…eveloper Balance sample (dotnet#31902) * Fixed CollectionView card height appears larger in Developer Balance sample * Issue31897 modified test class * Issue31897 Modified test sample * Issue31897 the fix comment has been updated * Modified the test samppe --------- Co-authored-by: devanathan-vaithiyanathan <[email protected]>
5 participants
Issue Details
In the Developer Balance sample, the CollectionView items appear larger than expected on iOS and Mac. Additional vertical space is observed within the cards.
Root Cause
Breaking PR: #30978
In that PR, when the content size isn’t set, the desired size of the CollectionView is used. This causes the issue when a horizontal CollectionView stretches to full size without resizing to its actual height.
Description of change
Instead of returning the desired size from the base, the content size is now updated based on the CollectionView orientation, ensuring proper size constraints are applied
Validated the behaviour in the following platforms
Issues Fixed
Fixes #31897
Screenshots