Skip to content

Conversation

@jfversluis
Copy link
Member

Description of Change

Removes the Android specific environment variable I added for Aspire in #31494. Since this implementation of the Aspire+MAUI integration is broken atm anyway, we can just remove this code since its also not needed for the native Aspire integration (see dotnet/aspire#11942).

This code wasn't great to begin with, let's remove it. I did leave the feature toggle intact in case we might want to use that in other scenarios.

Issues Fixed

Closes #32119

Closes #32120

Removed Android-specific environment variable handling code.
@jfversluis jfversluis added this to the .NET 10.0 GA milestone Oct 21, 2025
Copilot AI review requested due to automatic review settings October 21, 2025 20:37
@jfversluis jfversluis added the area-aspire Work that has to do with the Aspire integration label Oct 21, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes Android-specific environment variable file handling that was previously added for Aspire integration. Since the Aspire+MAUI integration approach has changed and no longer requires reading environment variables from a file on Android devices, this code is being removed as unnecessary. The feature toggle for environment variable configuration remains intact for potential future use.

Key Changes:

  • Removed Android-specific code that read environment variables from /data/local/tmp/ide-launchenv.txt
  • Eliminated file-based environment variable merging logic for Android platform

@jfversluis
Copy link
Member Author

/backport to release/10.0.1xx

@github-actions
Copy link
Contributor

Started backporting to release/10.0.1xx: https://github.com/dotnet/maui/actions/runs/18696960751

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-aspire Work that has to do with the Aspire integration p/0 Current heighest priority issues that we are targeting for a release.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants