Don't pack .NET Standard #32203
Open
Don't pack .NET Standard #32203
+4
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR prevents .NET Standard target framework versions from being included in NuGet packages. While .NET Standard targets remain in the codebase for MSBuild task compatibility, they are no longer intended for distribution.
Key Changes
- Adds MSBuild property to exclude .NET Standard TFMs from packaging
| <Import Project="Sdk.targets" Sdk="Microsoft.DotNet.Arcade.Sdk" /> | ||
|
|
||
| <PropertyGroup> | ||
| <IsPackable Condition="$(TargetFramework.Contains('netstandard'))">false</IsPackable> |
There was a problem hiding this comment.
The condition syntax is incorrect. MSBuild property references require $() around the entire property evaluation. Should be Condition=\"$(TargetFramework.Contains('netstandard'))\".
Suggested change
| <IsPackable Condition="$(TargetFramework.Contains('netstandard'))">false</IsPackable> | |
| <IsPackable Condition="$([System.String]::Copy('$(TargetFramework)').Contains('netstandard'))">false</IsPackable> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
.NET Standard was never supported, but just remained to help MSBuild tasks.
We don't need to actually ship them.