parsing other tag price ids #34
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ceblock_dealprice' ids
bluemix
changed the title
drawrowfly
reviewed
Jan 5, 2021
| @@ -1,4 +1,5 @@ | |||
| // @ts-nocheck | |||
| fs = require('fs'); | |||
| : 0; | ||
|
|
||
| output.price.current_price = $(`#priceblock_ourprice`)[0] ? this.geo.price_format($($(`#priceblock_ourprice`)[0].children[0]).text()) : 0; | ||
| var _price = 0; |
Owner
There was a problem hiding this comment.
let instead of var will be better
|
Can I also say that the price extraction doesn't work for almost every book that i have checked, they don't contain the id tag you are expecting. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello dear.
There are other ids than
priceblock_ourprice.I've added two more,
priceblock_dealprice(example)priceblock_saleprice(example)I am not a pro at JS, but, this code solved my issue issue #33 .
I've also attached the screenshots for clarification.