-
Notifications
You must be signed in to change notification settings - Fork 23
Drip List Blueprints #1606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Drip List Blueprints #1606
Conversation
|
🚅 Deployed to the app-pr-1606 environment in Drips App
|
700d684 to
b15d3f8
Compare
48b741c to
7aa07f2
Compare
809d18a to
73240a4
Compare
a7cdd61 to
1515c2b
Compare
…EDIT_DRIP_LIST_FLOW_DRIP_LIST_FRAGMENT
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR implements "Drip List Blueprints" functionality that allows external parties to submit a list of splits and receive a blueprint ID. Users can then be directed to the funder onboarding flow with this blueprint ID to pre-fill their Drip List configuration.
Key Changes:
- Added REST API endpoints for creating and retrieving blueprints stored in Redis with a 6-hour TTL
- Integrated blueprint loading into the funder onboarding flow with a new populate-blueprint step
- Enhanced the progress bar component to support centered text and custom styling for blueprint population
- Added comprehensive test coverage for the blueprint-based Drip List creation flow
Reviewed changes
Copilot reviewed 17 out of 18 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
src/routes/api/list-blueprints/+server.ts |
PUT endpoint to create blueprints with validation and Redis storage |
src/routes/api/list-blueprints/[blueprintId]/+server.ts |
GET endpoint to retrieve blueprints by ID with validation |
src/lib/utils/blueprints/schemas.ts |
Zod schemas defining blueprint structure and validation rules |
src/routes/(pages)/app/(flows)/funder-onboarding/+page.server.ts |
Server-side load function to fetch blueprint data from query params |
src/routes/(pages)/app/(flows)/funder-onboarding/+page.svelte |
Page component updated to pass blueprint data to stepper |
src/lib/flows/create-drip-list-flow/create-drip-list-stepper.svelte |
Updated to accept and forward blueprint data to flow steps |
src/lib/flows/create-drip-list-flow/create-drip-list-flow.ts |
Flow configuration updated to conditionally include blueprint population step |
src/lib/flows/create-drip-list-flow/steps/populate-blueprint/populate-blueprint.svelte |
New step component that hydrates blueprint splits into the form |
src/lib/flows/create-drip-list-flow/steps/choose-creation-mode/choose-creation-mode.svelte |
Updated to show blueprint mode UI and hide recipient selection options |
src/lib/flows/create-drip-list-flow/steps/build-list/build-list.svelte |
Added AccountId type import (appears unused) |
src/lib/utils/launch-create-drip-list.ts |
Updated modal launch to include blueprintOrBlueprintError parameter |
src/lib/components/stepper/types.ts |
Added progressBar support to AwaitPendingPayload type |
src/lib/components/stepper/components/await-step.svelte |
Integrated ProgressBar component rendering |
src/lib/components/progress-bar/progress-bar.svelte |
Enhanced with centered text option and improved styling |
tests/create-drip-list.spec.ts |
Added end-to-end test for blueprint-based Drip List creation |
tests/ecosystems.spec.ts |
Updated import path for ecosystem payload |
tests/payloads/create-blueprint-payload.json |
Test payload for blueprint creation |
tests/payloads/create-ecosystem-payload.json |
Test payload moved to payloads directory |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/lib/flows/create-drip-list-flow/steps/populate-blueprint/populate-blueprint.svelte
Show resolved
Hide resolved
src/routes/(pages)/app/(flows)/funder-onboarding/+page.server.ts
Outdated
Show resolved
Hide resolved
src/lib/flows/create-drip-list-flow/steps/populate-blueprint/populate-blueprint.svelte
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
efstajas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Approved
Uh oh!
There was an error while loading. Please reload this page.